Pre Pr

---
description: Run mandatory pre-PR checks before creating a pull request
allowed-tools: Bash(roslynator:*), Bash(dotnet:*), Bash(quickdup:*), Bash(gh:*), Bash(./tools/check-allocation-regression:*)
---

# Pre-PR Checklist

**MANDATORY**: Run this before creating any PR to GitHub.

## Execute All Steps In Order

### Step 1: Roslynator Fix

```bash
roslynator fix src/Asynkron.JsEngine

Then verify compilation:

dotnet build src/Asynkron.JsEngine

If build fails: Fix the issues and rerun roslynator before proceeding.

Step 2: Run Full Internal Unit Tests

dotnet test tests/Asynkron.JsEngine.Tests

Handle failures:

• Flaky tests: Rerun to confirm
• Broken tests: Fix before proceeding
• All tests MUST pass before moving to step 3

Step 3: Check for Code Duplication

quickdup --path src/Asynkron.JsEngine --ext .cs --select 0..20 --min 2 --exclude ".g."

If new duplications are found:

1. Refactor to eliminate duplications
2. Go back to Step 1 (roslynator fix)
3. Repeat until no new duplications

Step 4: Format Code

dotnet format src/Asynkron.JsEngine

Step 5: Allocation Regression Gate

Guard the evaluator hot-path allocation wins against silent regression:

./tools/check-allocation-regression

This re-measures Asynkron managed allocations for the benchmark smoke set and compares them to the committed tools/allocation-baseline.txt. It exits non-zero with a per-profile diff if any profile regresses beyond tolerance.

If it reports a regression:

• Unintended regression → investigate and reduce allocations before proceeding.
• Intentional change that legitimately moves the numbers → refresh and commit the baseline:

  ./tools/check-allocation-regression --update
  git add tools/allocation-baseline.txt
  

Step 6: Final Verification

Confirm all checks passed:

• Roslynator fix applied
• Code compiles cleanly
• All unit tests pass
• No new code duplications
• Code formatted
• No allocation regression (or baseline intentionally refreshed)

Step 7: Create PR

Only after ALL checks pass:

gh pr create --title "..." --body "..."

Important

• Do NOT skip any steps
• Do NOT create PR if any step fails
• Iterate until all checks pass