Ship It

Commit, push, create a PR, run review agents, fix issues, and merge for gunita.

## Step 1: Prepare the branch

Check the current git state:

```bash
git status
git branch --show-current

If on main/master:

1. Create a feature branch from the changes:

   git checkout -b <descriptive-branch-name>
   

2. Stage and commit all changes with a clear commit message.

If on a feature branch:

1. Stage and commit any uncommitted changes.
2. If there are no uncommitted changes, continue to Step 2.

Step 2: Push and create (or update) the PR

git push -u origin <branch-name>

Check if a PR already exists for this branch:

gh pr view <branch-name> --json number,url 2>/dev/null

If no PR exists, create one:

gh pr create --title "<concise title>" --body "## Summary

<1-3 bullet points describing the changes>

## Test plan

- [ ] `cargo build` compiles without warnings
- [ ] `cargo clippy` passes
- [ ] Manual testing of affected endpoints
"

If a PR already exists, note its number and continue.

Step 3: Review-fix loop

Repeat until all agents approve:

3a. Gather the diff

gh pr diff <PR-number>

3b. Launch review agents in parallel

Send a single message with Task tool calls so they run concurrently. Each agent receives the PR description and full diff.

Launch these agents:

1. Security reviewer (security-reviewer agent) — Scan for path traversal in media endpoints, SQL injection in rusqlite queries, Salita proxy abuse, cache poisoning, and unauthenticated API exposure.

2. Correctness reviewer (correctness-reviewer agent) — Check SQLite transaction safety, async/blocking boundary correctness, cache race conditions, Salita error handling, and media processing edge cases.

3. Code quality reviewer (code-quality-reviewer agent) — Evaluate Rust idioms, Axum patterns, error handling via AppError, SQL query structure, naming conventions, and frontend JS quality.

4. Media pipeline reviewer (media-pipeline-reviewer agent) — Check image processing correctness (RAW, resize, encode), cache coherence, thumbnail/preview/stream serving, and CID integration. Only launch this agent if the diff touches processing.rs, cache.rs, media.rs, or related files.

Each agent must end with a verdict:

VERDICT: APPROVE
VERDICT: APPROVE_WITH_NOTES
VERDICT: REQUEST_CHANGES

3c. Compile and post the review

Combine agent responses into a review summary and post it:

gh pr comment <PR-number> --body "<review summary>"

3d. Fix any issues

If any agent returned REQUEST_CHANGES:

1. Fix the issues they identified.
2. Run cargo clippy --all-targets and cargo fmt --check to verify.
3. Commit and push the fixes.
4. Return to step 3a.

If all agents returned APPROVE or APPROVE_WITH_NOTES, continue to Step 4.

Step 4: Merge

gh pr merge <PR-number> --squash --delete-branch

Print the merged PR URL. ```