# SDD — Spec-Driven Development Pipeline

You are the **orchestrator** for the full SDD pipeline:
PM Agent → Coding → Code Review → Test Gen → Test Review → Commit.

You collect output from each phase, show summaries to the user at approval gates,
and thread context forward.

## How phases are executed

Two execution mechanisms are used:

| Phase | Mechanism | Why |
|-------|-----------|-----|
| PM Agent (Phase 1) | `Skill(skill='pm-agent')` | dedicated skill file |
| Coding (Phase 2) | `Agent(subagent_type='general-purpose')` | no dedicated skill; complex multi-file task |
| Code Review (Phase 3) | `Skill(skill='code-review')` | dedicated skill file |
| Auto-fix (Phase 3 loop) | `Agent(subagent_type='general-purpose')` | needs inline review findings injected |
| Test Generation (Phase 4) | `Skill(skill='test-gen')` | dedicated skill file |
| Test Review (Phase 5) | `Skill(skill='test-review')` | dedicated skill file |
| Test Fix (Phase 5 loop) | `Agent(subagent_type='general-purpose')` | needs inline review findings injected |

**Never** use `Agent(subagent_type='pm-agent')`, `Agent(subagent_type='code-review')`,
etc. — those names are not built-in agent types and will fail. Skill files live in
`.claude/commands/` and are invoked via the `Skill` tool only.

## Input

`$ARGUMENTS` — a Jira issue key or URL, e.g.:
`SVY-21080` or `https://servoy-cloud.atlassian.net/browse/SVY-21080`

---

## Phase 1 — PM Agent: Jira → Spec

Invoke the skill:

Skill(skill='pm-agent', args='$ARGUMENTS')


The skill reads `.claude/commands/pm-agent.md` and follows its instructions.
Its final output will be exactly the relative path to the spec file it created.
Record that path as `SPEC_PATH`.

**🛑 HUMAN GATE — Spec approval**

Tell the user: "Phase 1 complete. Spec written at `SPEC_PATH`. Please review it
(you can open the file in your editor), then let me know:"

Ask (single-select):
- **Approve** — proceed to implementation
- **Request changes** — provide feedback and I'll revise the spec

If the user requests changes, apply the edits yourself (read the spec, make the
changes with `eclipse-coder_replaceString`, save). No sub-agent needed for minor
revisions. For substantial rewrites, spawn a general-purpose agent:

Agent(subagent_type='general-purpose', prompt=""" Read AGENTS.md, CLAUDE.md, and the spec at SPEC_PATH. Revise the spec based on this feedback from the product owner:

Keep the same file path. Use eclipse-coder_replaceString or eclipse-coder_replaceFileContent. Output: exactly the spec file path on a single line. """)


Loop this gate until the user approves.

---

## Phase 2 — Coding Agent: Spec → Implementation

Spawn a general-purpose agent (no skill file exists for coding):

Agent(subagent_type='general-purpose', prompt=""" You are a senior developer implementing a feature for the Servoy Eclipse IDE.

Read these files first to understand conventions:

AGENTS.md (tool policy, workflow, project structure)
CLAUDE.md (project instructions)
SPEC_PATH (the full spec — this is your implementation contract)

Implement everything described in the spec's "Implementation plan" section.

Do NOT create test classes or test files. Test generation is handled separately in Phase 4. If the implementation plan lists a test file step, skip it — production code only.

Mandatory post-edit workflow for every Java file you touch:

eclipse-coder_organizeImports
eclipse-coder_formatFile
eclipse-ide_getCompilationErrors — fix all errors before moving to the next file
If quick fixes are available: eclipse-ide_executeQuickFix
Fix any blocking Spotbugs issues (two highest severity levels)

Zero compilation errors must remain when you finish.

Output: a bulleted list of every file created or modified. """)


Record the file list as `CHANGED_FILES`.

---

## Phase 3 — Code Review

Invoke the skill:

Skill(skill='code-review', args='SPEC_PATH')


The skill reads `.claude/commands/code-review.md`. Its response must begin with
exactly `APPROVED` or `CHANGES NEEDED`.

Parse the first word of the response.

**If `CHANGES NEEDED`:**

Show the user the review output and ask (single-select):
- **Auto-fix** — spawn a coding agent with the review findings; re-run review afterwards
- **I'll fix manually** — pause here; tell me when you're done and I'll re-run the review
- **Override** — proceed to test generation despite the findings

If **Auto-fix**: spawn a general-purpose agent with the review findings injected:

Agent(subagent_type='general-purpose', prompt=""" You are a senior developer fixing code review findings. Read AGENTS.md, CLAUDE.md, and SPEC_PATH.

Fix every blocking issue in the review below. Apply the post-edit workflow (organizeImports → formatFile → getCompilationErrors → executeQuickFix) after each file. Zero errors when done.

Review findings: """)


Then re-run Phase 3 (`Skill(skill='code-review', args='SPEC_PATH')`).
Repeat until `APPROVED` or the user overrides.

---

## Phase 4 — Test Generation

Invoke the skill:

Skill(skill='test-gen', args='SPEC_PATH')


The skill reads `.claude/commands/test-gen.md`. Its output lists every test file
created and which acceptance criteria each covers.

Record the list as `TEST_FILES`.

---

## Phase 5 — Test Review

Invoke the skill:

Skill(skill='test-review', args='SPEC_PATH')


The skill reads `.claude/commands/test-review.md`. Its response must begin with
exactly `APPROVED` or `CHANGES NEEDED`.

**If `CHANGES NEEDED`:** spawn a general-purpose agent with the review findings injected:

Agent(subagent_type='general-purpose', prompt=""" You are a test engineer improving an existing test suite. Follow the instructions in .claude/commands/test-gen.md exactly. Also read AGENTS.md and CLAUDE.md.

Spec: SPEC_PATH

Address every blocking issue in the test review below. Also add missing coverage identified in the review.

Test review findings: <full test review outpu ```

Sdd

Maintain Sdd?

Maintain Sdd?

Related loops